The type declaration snippets should generate file headers. #2813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hopehadfield brought up that this makes the case of nested classes annoying. Maybe there's a way I can detect the context (are we already within a type declaration), in order to include/exclude the file header. |
rgrunber
force-pushed
the
filecomment_typedecl_snippets
branch
from
5beae99
to
b720935
Compare
- class/interface/record snippets should generate a file header if defined - Do not generate file header if compilation unit contains a type Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
rgrunber
force-pushed
the
filecomment_typedecl_snippets
branch
from
b720935
to
be28d37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change, the class/interface/record snippets ignored
java.templates.fileHeader. Now they should respect it as seen below. This worked correctly for the quick-fixes that generated a new type declaration in a new file (eg. "Create new class '...'" since that code is a bit different.@hopehadfield feel free to have a look since you've been looking into the snippets recently.