Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move snippet suggestions above keywords in completion list #2892

Merged
merged 1 commit into from
Oct 14, 2023

Conversation

hopehadfield
Copy link
Contributor

@hopehadfield hopehadfield commented Oct 3, 2023

Fixes redhat-developer/vscode-java#2584

Before:
Screenshot from 2023-10-12 16-21-00
Screenshot from 2023-10-03 13-36-41

After:
Screenshot from 2023-10-03 13-23-19
Screenshot from 2023-10-03 13-25-24

@hopehadfield hopehadfield force-pushed the 2584-keywords branch 3 times, most recently from 181920a to 04e1b06 Compare October 10, 2023 17:58
@hopehadfield hopehadfield marked this pull request as ready for review October 10, 2023 19:06
@rgrunber rgrunber self-requested a review October 11, 2023 22:37
Signed-off-by: Hope Hadfield <hhadfiel@redhat.com>
@rgrunber rgrunber merged commit 342d700 into eclipse-jdtls:master Oct 14, 2023
6 checks passed
@rgrunber
Copy link
Contributor

Screenshot from 2023-10-03 13-23-19

As a note, the behaviour here is a client-side issue (it's arguable whether it's a feature or not). Basically, the language server correctly uses sortText to place the if keyword item at the bottom. However, since the if keyword fully matches what the client is filtering on (if), those matching items seem to prioritized.

filtertext-vs-sorttext

@hopehadfield hopehadfield deleted the 2584-keywords branch October 18, 2023 15:04
@rgrunber rgrunber added this to the End October 2023 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common code snippets not on top of the completion list
2 participants