-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix (jkube-kit/config) : Add workaround for trace level logging problems with KubernetesClient (#1950) #2006
Conversation
…ems with KubernetesClient (eclipse-jkube#1950) Add a workaround to forcefully set `org.slf4j.simpleLogger.log.okhttp3.logging.HttpLoggingInterceptor` property to `BASIC` to prevent OkHttp's HttpLoggingInterceptor to interfere with KubernetesClient operations. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Eclipse JKube CI ReportStarted new GH workflow run for #2006 (2023-01-18T15:05:36Z) ⚙️ JKube E2E Tests (3949976564)
|
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #2006 +/- ##
=========================================
Coverage 54.09% 54.09%
- Complexity 4048 4051 +3
=========================================
Files 480 480
Lines 21055 21063 +8
Branches 2812 2814 +2
=========================================
+ Hits 11389 11395 +6
Misses 8500 8500
- Partials 1166 1168 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After discussing the issue with one of the affected parties, the workaround might prevent other valid usages of the request tracing. Let's leave this at the moment, and see if we can actually replace the OkHttp logging interceptor at the client level (might be easier than initially anticipated). |
Description
Related to #1950
org.slf4j.simpleLogger.log.okhttp3.logging.HttpLoggingInterceptor
property toBASIC
to prevent OkHttp's HttpLoggingInterceptor to interfere with KubernetesClient operations.I've tested this workaround on https://github.com/luigidemasi/spring-boot-camel-config/tree/omp-with-trace as well. This seems to fix it.
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist