Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #3286: Replace deprecated asList() in Web App Generator Test #3302

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Issue #3286: Replace deprecated asList() in Web App Generator Test #3302

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6dc353b
Issue #3286: Replace deprecated asList() in Web App Generator Test
ShivamChavan01 Aug 4, 2024
e5a7550
Removed the unused Imports
ShivamChavan01 Aug 6, 2024
14378df
Used Only Imports which are required
ShivamChavan01 Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...enerator/webapp/src/test/java/org/eclipse/jkube/generator/webapp/WebAppGeneratorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@
import java.util.List;
import java.util.Map;
import java.util.Properties;

import org.assertj.core.api.InstanceOfAssertFactories;
import org.eclipse.jkube.generator.api.GeneratorContext;
import org.eclipse.jkube.kit.common.JavaProject;
import org.eclipse.jkube.kit.common.KitLogger;
import org.eclipse.jkube.kit.common.Plugin;
import org.eclipse.jkube.kit.common.*;
rohanKanojia marked this conversation as resolved.
Show resolved Hide resolved
import org.eclipse.jkube.kit.config.image.ImageConfiguration;
import org.eclipse.jkube.kit.config.image.build.BuildConfiguration;
import org.eclipse.jkube.kit.config.image.build.JKubeBuildStrategy;
Expand Down Expand Up @@ -126,7 +126,7 @@ void withDefaultHandler_shouldAddImageConfiguration() throws IOException {
}})
.extracting(BuildConfiguration::getAssembly)
.hasFieldOrPropertyWithValue("excludeFinalOutputArtifact", true)
.extracting("inline.files").asList().extracting("destName")
.extracting("inline.files").asInstanceOf(InstanceOfAssertFactories.list(AssemblyFile.class)).extracting("destName")
.containsExactly("ROOT.war");
}

Expand Down Expand Up @@ -172,7 +172,7 @@ void withOverriddenProperties_shouldAddImageConfiguration() throws IOException {
.extracting(BuildConfiguration::getAssembly)
.hasFieldOrPropertyWithValue("excludeFinalOutputArtifact", true)
.hasFieldOrPropertyWithValue("user", "root")
.extracting("inline.files").asList().extracting("destName")
.extracting("inline.files").asInstanceOf(InstanceOfAssertFactories.list(AssemblyFile.class)).extracting("destName")
.containsExactly("some-context.war");
}

Expand Down