Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JNoSQL Redis Database API] - Fixed broken connection issue and added sentinel and cluster support #297

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

dearrudam
Copy link
Contributor

@dearrudam dearrudam commented Nov 18, 2024

Changes

…nd redis-sentinel

Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
@genie-jnosql
Copy link
Collaborator

Can one of the admins verify this patch?

Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
Signed-off-by: Maximillian Arruda <dearrudam@gmail.com>
@dearrudam dearrudam marked this pull request as ready for review November 19, 2024 06:15
@dearrudam
Copy link
Contributor Author

dearrudam commented Nov 19, 2024

@otaviojava, could you please review it?

I implemented the sample projects on the branch feature/redis-sample of the https://github.com/JNOSQL/demos-ee/ repo. Such branch is ready to be merged to the main branch by this PR: JNOSQL/demos-ee#18. The sample projects are:

  • microprofile-liberty-redis-single-node
  • microprofile-liberty-redis-sentinel
  • microprofile-liberty-redis-cluster

So, feel free to test this implementation against these sample projects. After building this branch and generating the 1.1.3-SNAPSHOT version locally, you just need to replace the jnosql.version property in the POM of each sample project mentioned above. Each sample project has a README.adoc with build and startup instructions.

Let me know if you need more clarification.

Thanks

@otaviojava otaviojava merged commit dbeb9c1 into main Nov 19, 2024
3 checks passed
@otaviojava otaviojava deleted the added-redis-sentinel-and-cluster-support branch November 19, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants