Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing schema generates too many warnings #336

Closed
fbricon opened this issue Mar 28, 2019 · 1 comment · Fixed by #361
Closed

Missing schema generates too many warnings #336

fbricon opened this issue Mar 28, 2019 · 1 comment · Fixed by #361
Assignees
Labels
bug Something isn't working validation
Milestone

Comments

@fbricon
Copy link
Contributor

fbricon commented Mar 28, 2019

Create a document, referencing an unreachable schema, then each node of that document will get a warning about it:

Screen Shot 2019-03-28 at 5 10 27 PM

Try with:

<?xml version="1.0" encoding="UTF-8"?>
<invoice xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
 xsi:noNamespaceSchemaLocation="invoice.xsd">
  <date>2017-11-30</date>
  <number>5235</number>
  <products>
    <product />
  </products>
  <payments>
    <payment amount="770.00" method="credit"/>
  </payments>
</invoice>

Moreover, the warning range is incorrect, it selects the closing bracket.

@fbricon
Copy link
Contributor Author

fbricon commented Mar 28, 2019

mmm I see that IDEA generates the same warnings (with proper ranges though). So fixing that range should definitely be the 1st step. We can discuss about fixing the amount of diagnostics

@fbricon fbricon added bug Something isn't working validation labels Mar 28, 2019
@NikolasKomonen NikolasKomonen self-assigned this Apr 1, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Apr 26, 2019
…t duplicates

Fixes eclipse-lemminx#336, eclipse-lemminx#343

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen added this to the v0.6.0 milestone May 3, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue May 6, 2019
…t duplicates

Fixes eclipse-lemminx#336, eclipse-lemminx#343

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
fbricon pushed a commit that referenced this issue May 6, 2019
…t duplicates (#361)

Fixes #336, #343

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working validation
Projects
None yet
2 participants