Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "processing instruction" snippet to "xml declaration" #727

Closed
BalduinLandolt opened this issue May 27, 2020 · 1 comment · Fixed by #748
Closed

Rename "processing instruction" snippet to "xml declaration" #727

BalduinLandolt opened this issue May 27, 2020 · 1 comment · Fixed by #748
Assignees
@angelozerr
Labels
snippet
Milestone
0.12.0

Comments

@BalduinLandolt
Copy link
Contributor

this is totally minor, I just stumbled across it:
The snippet for the prolog is called "processing instruction":

https://github.com/eclipse/lemminx/blob/b0dd7ce255def2ec4311cc94138f2d9064fb0029/org.eclipse.lemminx/src/main/resources/org/eclipse/lemminx/services/snippets/prolog-snippets.json#L2

But technically, this is the "XML Declaration" and not a processing instruction as such. (At least according to Wikipedia: https://en.wikipedia.org/wiki/Processing_Instruction)
@angelozerr
Copy link
Contributor

angelozerr commented May 27, 2020 •
edited
Loading

I agree, it should be renamed to Insert xml declaration

It should be good to rename prolog-snippets.json to processing-instruction-snippets.json

@BalduinLandolt is there any chance to have some contribution? Please note that you must sign your CLA if you wish to contribute

@BalduinLandolt BalduinLandolt mentioned this issue May 27, 2020
Closed
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 29, 2020
@angelozerr
snippet calls xml declaration "processing instruction" which it's
4ad3775 
technically not

Fixes eclipse-lemminx#727

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr mentioned this issue May 29, 2020
Merged
angelozerr added a commit to angelozerr/lemminx that referenced this issue May 29, 2020
@angelozerr
Rename "processing instruction" snippet to "xml declaration"
9726f35 
Fixes eclipse-lemminx#727

Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr changed the title snippet calls xml declaration "processing instruction" which it's technically not Rename "processing instruction" snippet to "xml declaration" May 29, 2020
@angelozerr angelozerr added this to the 0.12.0 milestone May 29, 2020
@angelozerr angelozerr self-assigned this May 29, 2020
fbricon pushed a commit that referenced this issue May 29, 2020
@angelozerr @fbricon
Rename "processing instruction" snippet to "xml declaration"
3342ed0 
Fixes #727

Signed-off-by: azerr <azerr@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
snippet
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Rename "processing instruction" snippet to "xml declaration" angelozerr/lemminx
2 participants
@angelozerr @BalduinLandolt