New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG for 0.23.0 #1404

Merged

datho7561 merged 1 commit into eclipse-lemminx:main from JessicaJHee:changelog-0.23.0

Dec 14, 2022

Contributor

JessicaJHee commented Dec 12, 2022

Signed-off-by: Jessica He jhe@redhat.com

JessicaJHee force-pushed the changelog-0.23.0 branch from f29e7cf to 30041a5 Compare

December 12, 2022 21:37

datho7561 self-requested a review

December 12, 2022 21:59

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

JessicaJHee force-pushed the changelog-0.23.0 branch from 30041a5 to 13c76e2 Compare

December 13, 2022 16:25

datho7561 requested changes

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

JessicaJHee force-pushed the changelog-0.23.0 branch from 13c76e2 to eb52c48 Compare

December 13, 2022 17:26

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

rgrunber reviewed

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

JessicaJHee force-pushed the changelog-0.23.0 branch from eb52c48 to 6e30a16 Compare

December 13, 2022 19:10

Contributor

rgrunber commented Dec 14, 2022 •

edited

Loading

Evaluate the following PRs for inclusion. Each is a PR not included in the lemminx 0.23.0 milestone and a corresponding issue that was filed under vscode-xml. We should include these entries.

#1365
#1386
#1387
#1393
#1390

Otherwise, I think this changelog is in pretty good shape.

JessicaJHee force-pushed the changelog-0.23.0 branch from 6e30a16 to 275af8a Compare

December 14, 2022 15:33

Contributor

rgrunber commented Dec 14, 2022

One last thing to add to this PR. I would bump the version to 0.23.0-SNAPSHOT. Currently it sits at 0.22.1-SNAPSHOT. Only 2 pom files where this change needs to be done, but can also do it automatically with mvn org.eclipse.tycho:tycho-versions-plugin:set-version -DnewVersion=0.23.0-SNAPSHOT

JessicaJHee force-pushed the changelog-0.23.0 branch from 275af8a to 4cd7804 Compare

December 14, 2022 16:24

rgrunber approved these changes

View reviewed changes

Contributor

rgrunber left a comment

I think we're ready to merge if there's nothing else to include in the release.

CHANGELOG.md Outdated Show resolved Hide resolved


          Update CHANGELOG for 0.23.0

5b75c44

Signed-off-by: Jessica He <jhe@redhat.com>

JessicaJHee force-pushed the changelog-0.23.0 branch from 4cd7804 to 5b75c44 Compare

December 14, 2022 17:52

rgrunber approved these changes

View reviewed changes

datho7561 approved these changes

View reviewed changes

Contributor

datho7561 left a comment

Looks good. Thanks Jessica!

datho7561 merged commit 75eaf24 into eclipse-lemminx:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet