Handles setting a space before a self closing tag end bracket. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolasKomonen
force-pushed
the
whitespaceAutoClosingTag
branch
from
aed15df to
06d9a34
Compare
fbricon
reviewed
Nov 14, 2018
...pse.lsp4xml/src/test/java/org/eclipse/lsp4xml/settings/capabilities/XMLCapabilitiesTest.java
Show resolved
Hide resolved
|
OK to merge once the missing javadoc on XMLFormattingOptions(boolean) is added |
Fixes eclipse-lemminx#197 Also fixed an unknown issue where the new settings would replace existing and not update the current ones. In the case of a setting not being sent from the client, the default value set on the server side would be lost in XMLFormattingOptions anymore. Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
NikolasKomonen
force-pushed
the
whitespaceAutoClosingTag
branch
from
06d9a34 to
86644a6
Compare
|
@fbricon updated |
fbricon
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #197
Also fixed an unknown issue where the new settings would replace existing and not
update the current ones. In the case of a setting not being sent from the client,
the default value set on the server side would be lost in XMLFormattingOptions
anymore.