-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add xml-model snippets. #752
Add xml-model snippets. #752
Conversation
It seems perfect |
I added "fixes" to the PR description. |
If you pushed your branch already, then you'll need to force push ( That's what you'll need to do since you need to fix the conflict in this PR |
Allrighty... all conflicts resolved, all checks pass. Unless there are any further changes necessary, I'd say it can be merged. :) |
Never mind... I'll fix it and then try again. Sorry! |
Adjust unit tests accordingly. Fixes #699. Signed-off-by: Balduin Landolt <balduin.landolt@hotmail.com>
Now I'm officially confused: No idea why |
It's not your fault, I created an issue for that #753
@BalduinLandolt congrats for your first contribution! Contributing to a new project can be boring (need to sign some things, need to add some header, need to write commit with a given format, etc...), but now you have done that I think your future (I hope) contribution will be more easy to do. Anyway thank a lot for your PR! |
This PR adds all the changes form #730, but this time it should work.
All requests for changes are included too.
Fixes #699.
Signed-off-by: Balduin Landolt balduin.landolt@hotmail.com