Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why not logging uncaught exception ? #1287

Closed
jvermillard opened this issue Jul 14, 2022 · 2 comments
Closed

Why not logging uncaught exception ? #1287

jvermillard opened this issue Jul 14, 2022 · 2 comments
Labels
bug Dysfunctionnal behavior core Impact core of Leshan

Comments

@jvermillard
Copy link
Contributor

https://github.com/eclipse/leshan/blob/master/leshan-core-cf/src/main/java/org/eclipse/leshan/core/californium/CoapAsyncRequestObserver.java#L101

using something like: LOG.warn("Uncaught exception during onResponse callback", e); would simplify the debug, WDYT?
@sbernard31
Copy link
Contributor

Totally 👍 looks like a bug !

@sbernard31 sbernard31 added bug Dysfunctionnal behavior core Impact core of Leshan labels Jul 18, 2022
@jvermillard
Copy link
Contributor Author

ok let me fix that

jvermillard added a commit that referenced this issue Jul 18, 2022
@jvermillard
fix #1287 : log uncaught callback exceptions
0fc43e6 
Signed-off-by: Julien Vermillard <jvermillard@sierrawireless.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Dysfunctionnal behavior core Impact core of Leshan
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sbernard31 @jvermillard