Rethrowing duplication errors as CodecException

[Warmek]

Question

When a SEND containing a duplicates (same path + timestamp) is received, TimestampedLwM2mNodes.Builder::build throws an IllegalArgumentException.

if (noDuplicate && previous != null) {
    throw new IllegalArgumentException(String.format(
             "Unable to create TimestampedLwM2mNodes : duplicate value for path %s. (%s, %s)",
             internalNode.path, internalNode.node, previous));
}

That exception is just catched in SendResource::handlePOST, to be sent to the SendListener::onError callback and rethrown.

} catch (RuntimeException e) {
    sendHandler.onError(registration, e);
    throw e;
}

Maybe it would be better to catch that exception (in LwM2mNodeSenMLDecoder::decodeTimestampedNodes) and rethrow as CodecException?

} catch (SenMLException | IllegalArgumentException e) {
        String hexValue = content != null ? Hex.encodeHexString(content) : "";
        throw new CodecException(e, "Unable to decode nodes : %s", hexValue, e);
}

[sbernard31]

Yep totally agree ! Good catch 👍 !

[Warmek]

I've made a commit on opl/rethrow_illegalArgumentException

[sbernard31]

Yep I think you can create a PR

[sbernard31]

Fix in master by #1377.

Thx @Warmek for catching this 😉 !