Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan for 2.0.0-M17 🎯 #1670

Closed
sbernard31 opened this issue Nov 8, 2024 · 18 comments
Closed

Plan for 2.0.0-M17 🎯 #1670

sbernard31 opened this issue Nov 8, 2024 · 18 comments

Comments

@sbernard31
Copy link
Contributor

sbernard31 commented Nov 8, 2024

This issue is about preparing the 2.0.0-M17 release.

2.0.0-M17 was asking by #563 (comment)

Let's discuss about it.

What is currently included for M17:

New commits in master since M16 :

8bd441659: GH-1674: Fix NPE when creating Composite failure Response
5f0d21058: Upgrade to netty 4.1.115
096e594f4: Update SECURITY.md with Jetty 9.x EOL information
40038daf9: [ci] update .trivyignore
0735507b1: [ci] Use HACK to get vulnerabilies db of trivy.
6f2f834a0: [ci] Add .trivyignore
314880ecb: [ci] always use latest version of trivy to check vulnerabilities
8dab3f73a: Upgrade to most recent version of jetty 9.x for demo
2db34981c: Integration of Californium 3.13.0
95fbcf43c: Add API to add several server endpoints to LeshanTestServerBuilder
c6972d83b: Return Code/exception onWaitFor**Failure method of LeshanTestClient
7db3aec99: Add support of several endpoint address to ReverseProxy test utility
812726acb: Add default toString to AbstractLwM2mResponse
7dd230c0a: Clean TestServerBuilder use argument instead of attribute
1a3f280b0: Fix tests about Dynamic IP using ReverseProxy...
88f161ab7: Add CLI Option to client demo to control if endpoint name should be sent
8e5e95229: GH-1457: Add Optional Endpoint Name support.
a878c188c: GH-1654: improve SenMLCborPackSerDes error message.
222901423: Update demo webapp dependencies.
6f3b56456: Fix missing '[ ]' when convert IPv6 address to URI.
0f936f2cf: Remove static EndpointUriUtil by dynamic  EndpointUriHandler interface.
174939bc0: Add EndpointUriParser interface and default implementation
9ef75aacd: Replace Java URI usage by EndpointUri
30dbe5e57: Use BigDecimal instead of double  for decimal LWM2M Attribute
ec5764825: Use Alternate path in SenML payload.
02b7538a0: GH-1637: Add some timestamp support to Read/Observe Composite operation
ccd7bc91e: Merge VersionTest in LwM2mTest
629352345: Change maven import for junit5
47890ddd8: Add virtualHost attribute to equals/hashcode of IpPeer.
70eec7dee: GH-1504: Clean and Test custom equals() and hashcode() method
18b814714: GH-1649: Fix NPE, log warn message when no registration on notification.
7a52fbf10: GH-1650: Fix demo-server about unexpected "Device is not awake" message
baa124fda: GH-1645: Add very simple Queue mode support to Leshan Server Demo.
ecf87f32a: Update demo webapp dependencies (again)
3218946d9: Update demo webapp dependencies.
8281f2345: SendRequest constructor should send InvalidRequestException
583807b38: Make SenMLCBOR decoding customizable.
3d03a8ef6: GH-1634: change log level from ERROR to WARN in ServerEndpointsProvider

What should be added to M17:

Should we integrate that 👇 ?

About library itself ?

that ☝️ PRs are pretty impacting, so better to keep some time between integration in master and the release so we can get sandbox users feedback/testing.

About demo ?

Do you have any other needs for M17 ?

➡️ : We decide to not integrate this for 2.0.0-M17

Redis Store Compatibility break :

No Redis break in master, but there will be if we integrate :

➡️ : No Redis Break as we decide to not integrate this for 2.0.0-M17

When ?

We need to decide let me know ?

➡️ : start of next week (around 25th/26th november

@sbernard31
Copy link
Contributor Author

any plan for M17? I'm mainly interested in the Californium upgrade which fixes a memory leak

If some of you need to fix that very quickly : you should be able to use Leshan 2.0.0-M16 with Californium 3.13.0.

@jvermillard, about Gateway Object this release will probably change behavior of SenML encoding/decoding, see :#1237 (comment).

@sbernard31
Copy link
Contributor Author

@jvermillard, @JaroslawLegierski, @cyril2maq, @slaft, @niklas-sparfeld-gcx

Let me know, if you have any opinion about that 🙏

@jvermillard
Copy link
Contributor

For object 25, since I don't use (yet) senml with it it's fine. For the scope of master as it is, is fine

@niklas-sparfeld-gcx
Copy link

We've implemented persistence of Registrations and Observations and I'm currently clarifying whether tying the Registrations to the server endpoint URI would affect us. It's possible, I'll get back to you once I have the answers.

All other changes are fine with us 👍

@sbernard31
Copy link
Contributor Author

@jvermillard could you give a approximate date when you need the release ?

@jvermillard
Copy link
Contributor

end of November/start of December would work for me

@niklas-sparfeld-gcx
Copy link

In our setup, we won't have issues with Registrations or Observations being tied to the server-endpoint. We're not opposed to the change as far as I can tell.

@sbernard31
Copy link
Contributor Author

With current feedback from you, I propose we do not integrate :

Then I integrate it just after the release, so we increase chances to get feedback from sandbox users.

We will wait for Orange feedback but If there is nothing more to add, we can target a release for the end of the month.

You could already try to integrate current master in your application and see if it works for you.
You can use nightly build to test master (see #885 ==> I guess I should create a better documentation for that ... 😬)

@JaroslawLegierski
Copy link
Contributor

We will wait for Orange feedback but If there is nothing more to add, we can target a release for the end of the month.

We are OK with #1655 #1656 it seems to not store any “instance dependence things” on Redis (such as instance IP or sth) and therefore should not impacting on Leshan cluster management

@sbernard31
Copy link
Contributor Author

OK so we can go with a code freeze on master ❄️.
Following : #1670 (comment)

@jvermillard, @JaroslawLegierski, @cyril2maq, @slaft, @niklas-sparfeld-gcx

Please let me know, if you plan or don't plan to test the master branch before the release. 🙏

Once I've received your reply and eventually the green light from each of you who plan to test master, I'll launch the release process.

@slaft
Copy link

slaft commented Nov 18, 2024

The tests are in progress on our side. I'll let you know when it's done.

@niklas-sparfeld-gcx
Copy link

We're good 👍

@jvermillard
Copy link
Contributor

jvermillard commented Nov 18, 2024

I just tested quickly: adapted to new modules name and packages rename, and it looks like it is working 👍

Small feedback, I got confused by the module names appearing in the leshan mvn build screen:

image

and the artifact ID you need to use in your pom.xml like: leshan-tl-cf-server-coap

would be better to use a name looking like a name and not an artifact ID, for example in place of

  <artifactId>leshan-tl-cf-client-coap</artifactId>
  <packaging>bundle</packaging>
  <name>leshan-transport-californium-client-coap</name>

to

  <artifactId>leshan-tl-cf-client-coap</artifactId>
  <packaging>bundle</packaging>
  <name>Leshan transport layer Californium CoAP client</name>

@slaft
Copy link

slaft commented Nov 18, 2024

We've completed the tests. We came across this issue: #1674

@sbernard31
Copy link
Contributor Author

thx @slaft, I will look at this tomorrow !

@sbernard31
Copy link
Contributor Author

I'm waiting for @slaft feedback for #1676.

Once we get it we are good to release M17, maybe next week.

@sbernard31
Copy link
Contributor Author

#1676 is now integrated in master.

So I think we are good
If we don't face any "surprise" until it, I plan to release M17 begin of next week.

@sbernard31
Copy link
Contributor Author

Release 2.0.0-M17 is out now.

Thx guys for your help 😉 !

I will now integrate PRs we previously talk about in master : #1670 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants