Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JLine2 and Picocli to reimplement leshan-client-demo Interactive CLI #1064

Merged
merged 3 commits into from
Aug 3, 2021

Conversation

sbernard31
Copy link
Contributor

It could be possible to use JLine3 but it needs Java 8 and for now we are stucked to Java 7. (See #924)

We move from SimpleLogger to logback to be able to implement custom TerminalAppender.
Some other reason to move to logback :

Drawback client will be clearly heavier with move to :

  • picocli (instead of common-cli)
  • jline (instead of nothing)
  • logback (instead of SimpleLogger)

But we think that leshan-client-demo does not target so small devices and so usability improvement should worth it.

The usability improvement are :

  • usage help
  • autocompletion
  • history / search history
  • color

At code point of view, code is clearer and should be easier to maintain (e.g. adding new commands)

interactive-help

@sbernard31 sbernard31 changed the title Use JLine2 to reimplement leshan-client-demo Interactive CLI Use JLine2 and Picocli to reimplement leshan-client-demo Interactive CLI Jul 29, 2021
@sbernard31 sbernard31 changed the base branch from picocli to master August 3, 2021 11:59
@sbernard31 sbernard31 merged commit 6ea0b6a into master Aug 3, 2021
@sbernard31 sbernard31 deleted the jline branch August 16, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant