Update BindingMode to be LWM2M 1.1 compliant and support Q parameter. #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbernard31
commented
Oct 12, 2020
| @@ -34,6 +35,7 @@ | |||
| private final Long lifetime; | |||
| private final String lwVersion; | |||
There was a problem hiding this comment.
I should maybe change the type of this attribute to Version (same in Registration object) 🤔
sbernard31
force-pushed
the
Binding_mode
branch
from
260303c to
e8296c1
Compare
|
I read more about binding mode. I think this PR is not OK I need to change it. |
sbernard31
force-pushed
the
Binding_mode
branch
2 times, most recently
from
b020057 to
6553441
Compare
|
This time I think it's OK. See : |
|
Need more work about bootstrap part ... 😖 |
sbernard31
force-pushed
the
Binding_mode
branch
from
6553441 to
c073868
Compare
sbernard31
force-pushed
the
Binding_mode
branch
from
c073868 to
cf80f3b
Compare
sbernard31
force-pushed
the
Binding_mode
branch
from
cf80f3b to
2f75190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is several changes in LWM2M 1.1 about binding mode :
This PR aims to support new format, trying to keep compatible with LWM2M 1.0.
Here some discussion about LWM2M changes about Binding Mode.
(I will maybe add test about that to this PR)