Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support workspaceFolders proposal #132

Closed
mickaelistria opened this issue Nov 14, 2017 · 3 comments
Closed

Support workspaceFolders proposal #132

mickaelistria opened this issue Nov 14, 2017 · 3 comments
Milestone

Comments

@mickaelistria
Copy link
Contributor

microsoft/language-server-protocol#298 (comment) covers a discussion about allowing multi root/projects in language servers. This is not finalized in the protocol specification yet, but the vscode client api already covers it. This seems to be an important step forward and a major change, so it would be nice to start investigating support for it soon.

See https://bugs.eclipse.org/bugs/show_bug.cgi?id=526489 (PS: you should ask webmaster to remove bugzilla component if you're not using it).

mickaelistria added a commit to mickaelistria/lsp4j that referenced this issue Nov 14, 2017
Signed-off-by: Mickael Istria <mistria@redhat.com>
mickaelistria added a commit to mickaelistria/lsp4j that referenced this issue Nov 15, 2017
Signed-off-by: Mickael Istria <mistria@redhat.com>
@martinlippert
Copy link

Is there a way to get the related pull request accepted and a snapshot build that includes this up somewhere? I am eagerly waiting for this to make our language servers ready for the latest VSCode 1.18 release (which released support for multi-root workspaces).

@mickaelistria
Copy link
Contributor Author

FYI, I've prepared a patch in LSP4E which takes advantage of this change in LSP4J to implement multi-root support, and it seems to work with JDT-LS https://git.eclipse.org/r/#/c/111750/
That doesn't validate everything though as JDT-LS ignores the "static" capabilities and mostly go through the registerCapability approach; but the operations to change workspaceFolder seem to work as expected between LSP4E and JDT-LS, using LSP4J as API on client side.

mickaelistria added a commit to mickaelistria/lsp4j that referenced this issue Nov 17, 2017
Signed-off-by: Mickael Istria <mistria@redhat.com>
mickaelistria added a commit to mickaelistria/lsp4j that referenced this issue Nov 20, 2017
Signed-off-by: Mickael Istria <mistria@redhat.com>
spoenemann added a commit that referenced this issue Nov 20, 2017
@svenefftinge
Copy link
Contributor

closing since #133 is merged

@spoenemann spoenemann added this to the v0.4.0 milestone Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants