Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make name field in WorkspaceFolder required #767

Merged
merged 3 commits into from
Sep 13, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ Fixed issues: <https://github.com/eclipse-lsp4j/lsp4j/milestone/29?closed=1>

Breaking API changes:

* The name field in WorkspaceFolder is no longer optional according to the specification.
* See [#741](https://github.com/eclipse-lsp4j/lsp4j/issues/741) for detailed discussion.

Nightly japicmp report: <https://download.eclipse.org/lsp4j/builds/main/japicmp-report/>

### [v0.21.1 (August 2023)](https://github.com/eclipse-lsp4j/lsp4j/releases/tag/v0.21.1)
Expand Down
11 changes: 4 additions & 7 deletions org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Original file line number Diff line number Diff line change
Expand Up @@ -7995,19 +7995,16 @@ class WorkspaceFolder {
@NonNull String uri

/**
* The name of the workspace folder. Defaults to the uri's basename.
* The name of the workspace folder. Used to refer to this
* workspace folder in the user interface.
*/
String name
@NonNull String name

new() {
}

new(@NonNull String uri) {
new(@NonNull String uri, @NonNull String name) {
this.uri = Preconditions.checkNotNull(uri, 'uri')
}

new(@NonNull String uri, String name) {
this(uri)
this.name = name
jnt0r marked this conversation as resolved.
Show resolved Hide resolved
}
}
Expand Down