Skip to content

Commit

Permalink
Run GH verification build on Windows too
Browse files Browse the repository at this point in the history
Fixes #1080
  • Loading branch information
HannesWell committed Aug 27, 2024
1 parent a4387fc commit 64e54d0
Show file tree
Hide file tree
Showing 3 changed files with 32 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
os: [ubuntu-latest, windows-latest, macos-latest]
runs-on: ${{ matrix.os }}
timeout-minutes: 45

Expand Down Expand Up @@ -45,7 +45,11 @@ jobs:
- name: Build m2e-core
uses: coactions/setup-xvfb@b6b4fcfb9f5a895edadc3bc76318fae0ac17c8b3 # v1.0.1
with:
run: mvn clean verify --batch-mode -Pits -Dtycho.p2.baselineMode=failCommon -Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true
run: >-
mvn clean verify --batch-mode -Pits
-Dtycho.p2.baselineMode=failCommon
-Dmaven.test.error.ignore=true -Dmaven.test.failure.ignore=true
-Dtycho.surefire.deleteWorkDir=true
- name: Upload Test Results
uses: actions/upload-artifact@834a144ee995460fba8ed112a2fc961b36a5ec5a # v4.3.6
with:
Expand Down
25 changes: 25 additions & 0 deletions m2e-parent/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,31 @@
</plugins>
</build>
</profile>
<profile>
<id>windows</id>
<activation>
<os>
<family>windows</family>
</os>
</activation>
<properties>
<!-- The Tycho baselinging does not yet work well on Windows.
Temporarily skip it until it is fixed.-->
<tycho.baseline.skip>true</tycho.baseline.skip>
</properties>
<build>
<plugins>
<plugin>
<groupId>org.eclipse.tycho</groupId>
<artifactId>tycho-p2-plugin</artifactId>
<version>${tycho-version}</version>
<configuration>
<baselineMode>warn</baselineMode>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>

<developers>
Expand Down
1 change: 1 addition & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@
<formats>
<linux>tar.gz</linux>
<macosx>tar.gz</macosx>
<win32>tar.gz</win32>
</formats>
</configuration>
</execution>
Expand Down

0 comments on commit 64e54d0

Please sign in to comment.