Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore insignificant licence change in baseline-check #1587

Closed
wants to merge 1 commit into from
Closed

ignore insignificant licence change in baseline-check #1587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions m2e-parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@
<ignore>META-INF/ECLIPSE_.SF</ignore>
<ignore>jars/*.jar</ignore>
<ignore>Eclipse-SourceReferences</ignore>
Comment on lines 121 to 122
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, even those shouldn't be ignored as they're supposed to be stable across rebuilds. And if they're not stable, then they should be made stable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately they are not stable since they contain the ID of the commit from which the bundle was build.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If configured correctly, the referenced commit is the last commit that has affected the particular module; which is stable as long as the bundle is not changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a point.
But I likely added this because it failed the build, but if it would work without ignoring that, it would be even better.

<ignore>Bundle-License</ignore>
</ignores>
<extensions>true</extensions>
</configuration>
Expand Down
Loading