FIX: unit test configuration handles deferred var @{x} from surefire/failsafe #1827
+172
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reckart
reviewed
Sep 9, 2024
| ILaunchConfiguration config = updatedConfigurations[0]; | ||
| String argLine = config.getAttribute(UnitTestSupport.LAUNCH_CONFIG_VM_ARGUMENTS, ""); | ||
| assertTrue(argLine.contains("-javaagent")); // resolved jacoco agent | ||
| assertTrue(argLine.contains("@{titi.tata}")); // unresolved property, maybe removing the placeholder would be |
There was a problem hiding this comment.
I'd say yes - removing it would probably be better ;)
Although I believe that in a CLI build, it would also not be resolved and stay as is.
There was a problem hiding this comment.
I hesitated but in the end I preferred a quick failure in the case of an undefined variable than spending time looking for where the problem comes from
@HannesWell, @laeubi, @akurtakov what are your thought on this ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #1824