Disable HTTP2 when building libwebsockets for docker images. #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ound eclipse-mosquitto#1211. Signed-off-by: Tom Parker <tparker@usgs.gov>
ralight
approved these changes
Jul 28, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #1211, Firefox cannot connect over websocekts with TLS when using HTTP2. Without HTTP2 support in libwebsockets the connections fallback to HTTP and are able to complete.
This work around has been successfully used by multiple commenters and tests well. This pull requests implements the work around when building Docker images.
Signed-off-by: Tom Parker tparker@usgs.gov