Bridge subscription failure will cause a disconnect #2935
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, bridged connections will silently ignore subscription errors. This PR changes that by forcing the bridge to reconnect whenever a failure is received in the SUBACK. The hope is that the failure is temporary, and that retrying will solve it.
The MR is composed of 4 commits. The first two add the basic functionality and test it. The last two make it optional (enabled by default).
Though a change in behavior, I suggest that by default a failure should cause a disconnect. A silent failure causes more trouble than it solves. If you disagree, please edit the commit and change it to false.
If you consider that giving the user the option is not needed, just discard the last 2 commits.
make test
with your changes locally?