Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bridge subscription failure will cause a disconnect #2935

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

abiliojr
Copy link
Contributor

Currently, bridged connections will silently ignore subscription errors. This PR changes that by forcing the bridge to reconnect whenever a failure is received in the SUBACK. The hope is that the failure is temporary, and that retrying will solve it.

The MR is composed of 4 commits. The first two add the basic functionality and test it. The last two make it optional (enabled by default).

Though a change in behavior, I suggest that by default a failure should cause a disconnect. A silent failure causes more trouble than it solves. If you disagree, please edit the commit and change it to false.

If you consider that giving the user the option is not needed, just discard the last 2 commits.

  • Have you signed the Eclipse Contributor Agreement, using the same email address as you used in your commits?
  • Do each of your commits have a "Signed-off-by" line, with the correct email address? Use "git commit -s" to generate this line for you.
  • If you are contributing a new feature, is your work based off the develop branch?
  • If you are contributing a bugfix, is your work based off the fixes branch?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run make test with your changes locally?

@abiliojr abiliojr changed the title Subscription disconnect Bridge subscription failure will cause a disconnect Oct 26, 2023
@ralight ralight force-pushed the develop branch 3 times, most recently from 028adb2 to 604b69a Compare March 26, 2024 12:43
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
…ions

Signed-off-by: Abilio Marques <abiliojr@gmail.com>
Signed-off-by: Abilio Marques <abiliojr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant