Use system limit on file descriptors for soft limit #3641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdbain-ibm
requested review from
charliegracie,
mstoodle and
youngar
as code owners
|
@genie-omr build all |
|
I am trying to get on one of the failing machines to investigate. The test passes on a local Linux box. |
Tested on MacOS and Ubuntu. |
|
@genie-omr build all |
|
The test fails if the hard and soft limits are the same finite value. Fixed. |
|
|
||
| /* lowering the hard limit is irreversible unless privileged */ | ||
| if (0 != geteuid()) { /* normal user */ | ||
| /* setting the hard limit from unlimited to a finite value has unpredictable results: | ||
| * the actual value may be much smaller than requested. | ||
| * In that case, just try setting it to the same value. | ||
| */ | ||
| uint64_t newHardLimit = (OMRPORT_LIMIT_UNLIMITED == rc) ? originalHardLimit: originalHardLimit - 1; | ||
| uint64_t newHardLimit = ((OMRPORT_LIMIT_UNLIMITED == rc) || (originalSoftLimit == softSetToHardLimit)) |
There was a problem hiding this comment.
This seems odd. Can you explain this in more detail?
There was a problem hiding this comment.
Comments updated.
If user tries to set the soft limit of file descriptors to unlimited on MacOS, use the system limit instead. Add unit test. Add diagnostics output to test. Clean up incorrect return values. Fixes eclipse-omr#3579 Signed-off-by: Peter Bain <peter_bain@ca.ibm.com> Signed-off-by: Peter Bain <peter_bain@ca.ibm.com>
|
@genie-omr build all |
charliegracie
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user tries to set the soft limit of file descriptors to unlimited on MacOS,
use the system limit instead.
Add unit test.
Fixes #3579
Signed-off-by: Peter Bain peter_bain@ca.ibm.com