Improve error message on duplicate class definition #11276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshipton
reviewed
Nov 25, 2020
1. Add an error message on LinkageError when a duplicate class definition is found. 2. Change setCurrentExceptionNLSWithArgs() to pass in NULL rather than an empty string as the default message. j9nls_lookup_message() directly returns the default message when it is not NULL and the locale is English, making the message in setCurrentExceptionNLSWithArgs() always to be the default empty string. Fixes eclipse-openj9#11243 Signed-off-by: Hang Shao <hangshao@ca.ibm.com>
DanHeidinga
reviewed
Nov 25, 2020
|
jenkins test sanity,extended zlinux jdk11 |
pshipton
approved these changes
Nov 26, 2020
|
@DanHeidinga any other concerns? |
DanHeidinga
approved these changes
Nov 26, 2020
nope. I'm good with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
definition is found.
than an empty string as the default message.
j9nls_lookup_message() directly returns the default message when it
is not NULL and the locale is English, making the message in
setCurrentExceptionNLSWithArgs() always to be the default empty string.
Fixes #11243
Signed-off-by: Hang Shao hangshao@ca.ibm.com