Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of pd shift vector evaluators #14768

Merged

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented Mar 23, 2022

Add comment explaining that writting 1 to MSB of M_4 supresses HW
overflow program interrupt.

Signed-off-by: Shubham Verma shubhamv.sv@gmail.com

@VermaSh
Copy link
Contributor Author

VermaSh commented Mar 23, 2022

@r30shah/@joransiu could I please get a review

Add comment explaining that writting 1 to MSB of M_4 supresses HW
overflow program interrupt.

Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
@VermaSh VermaSh force-pushed the improve_readability_of_pdshr_evaluator branch from 1ddcc86 to 8e700d5 Compare March 23, 2022 20:15
@VermaSh VermaSh changed the title Improve readability of pdshrVectorEvaluatorHelper Improve readability of pd shift vector evaluators Mar 23, 2022
@joransiu joransiu merged commit c9c0e15 into eclipse-openj9:master Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants