Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OpenJ9 build for Windows #16334

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

vsebe
Copy link
Contributor

@vsebe vsebe commented Nov 16, 2022

Update configuration for windows platform, switch bootjdk installation
directory to default location (home directory) for Windows machines.
Add optional error handling for intermittent failures.

Signed-off-by: Violeta Sebe vsebe@ca.ibm.com

@vsebe
Copy link
Contributor Author

vsebe commented Nov 16, 2022

@AdamBrousseau please review, thank you!.

@AdamBrousseau
Copy link
Contributor

Jenkins compile win jdk8,jdk11,jdk17

@vsebe vsebe force-pushed the openj9_win2019 branch 2 times, most recently from 461920d to ec852e0 Compare November 29, 2022 14:23
@AdamBrousseau
Copy link
Contributor

Jenkins compile win jdk8,jdk11,jdk17

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good with me now. I would like a sign-off from @pshipton as well though. Once we let it soak a few days we can roll out more machines and delete the old ones, also pending Pete's approval.

Copy link
Contributor

@AdamBrousseau AdamBrousseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump @pshipton for sign-off

println("Attempt to recompile, retry: ${retryCounter}")

try {
_ sh "make clean && ${get_compile_command()}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an underscore in the first column here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!
Removed.

return false
}

def recompile(startTime) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we want to do something with startTime, such as print it out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise it's not used, so could be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Update configuration for windows platform, switch bootjdk installation
directory to default location (home directory) for Windows machines.
Add optional error handling for intermittent failures.

Signed-off-by: Violeta Sebe <vsebe@ca.ibm.com>
@pshipton
Copy link
Member

pshipton commented Dec 6, 2022

jenkins compile win jdk8

@pshipton pshipton merged commit 5c8b34f into eclipse-openj9:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants