Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: Clean up UpcallThunkGen.cpp #16370

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Nov 27, 2022

This commit cleans up UpcallThunkGen.cpp code for AArch64 for better readability.

  • Rename the variable tempInt to argSize and resultSize.
  • Stop using the variables useMoreGPRs and useMoreFPRs.
  • Stop using the variables gprCount and fprCount.

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Nov 27, 2022

Jenkins test sanity alinux64,amac jdk19

@knn-k knn-k marked this pull request as ready for review November 28, 2022 02:34
@knn-k
Copy link
Contributor Author

knn-k commented Nov 28, 2022

FYI. @zl-wang @0xdaryl

@knn-k knn-k added the project:panama Used to track Project Panama related work label Nov 28, 2022
This commit cleans up UpcallThunkGen.cpp code for AArch64 for better
readability.

- Rename the variable tempInt to argSize and resultSize.
- Stop using the variables useMoreGPRs and useMoreFPRs.
- Stop using the variables gprCount and fprCount.

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k force-pushed the aarch64simplifyUpcall2 branch from 8e39761 to 33155e1 Compare November 30, 2022 02:47
@knn-k
Copy link
Contributor Author

knn-k commented Nov 30, 2022

Jenkins test sanity alinux64,amac jdk19

@knn-k knn-k requested a review from zl-wang December 5, 2022 00:16
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang
Copy link
Contributor

zl-wang commented Dec 5, 2022

tested already ... merge

@zl-wang zl-wang merged commit 4fb37ad into eclipse-openj9:master Dec 5, 2022
@knn-k knn-k deleted the aarch64simplifyUpcall2 branch December 5, 2022 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch:aarch64 comp:vm project:panama Used to track Project Panama related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants