-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize J9JavaVM->liveVirtualThreadList at startup #16384
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babsingh
force-pushed
the
null_checks_vt_list
branch
from
November 29, 2022 23:53
727c187
to
f10155c
Compare
This change fixes the below deadlock. Thread 1 wants exclusive VM access but it is unable to acquire exclusive VM access because Thread 2 also holds VM access. Thread 2 is waiting to acquire liveVirtualThreadListMutex and unable to proceed because Thread 1 holds liveVirtualThreadListMutex. This prevents both threads to proceed and leads to a deadlock. Thread 1: JVM_VirtualThreadMountEnd -> Acquires VM Access and liveVirtualThreadListMutex -> J9AllocateObject -> Multiple GC frames -> acquireExclusiveVMAccess Thread 2: JVM_VirtualThreadMountEnd -> Acquires VM Access -> Blocked to enter liveVirtualThreadListMutex Related: eclipse-openj9#16340 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
null_checks_vt_list
branch
from
November 30, 2022 00:21
f10155c
to
7121794
Compare
jenkins test sanity amac jdk19 |
Multiple failures observed; it may not be feasible to adopt this solution; alternate solution created: #16389.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the below deadlock.
Thread 1 wants exclusive VM access but it is unable to acquire
exclusive VM access because Thread 2 also holds VM access.
Thread 2 is waiting to acquire liveVirtualThreadListMutex and
unable to proceed because Thread 1 holds liveVirtualThreadListMutex.
This prevents both threads to proceed and leads to a deadlock.
Related: #16340 (comment)
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com