Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable vectorized blend() IL opcode #16393

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

midronij
Copy link
Contributor

@midronij midronij commented Nov 30, 2022

Re-enable blendIntrinsicHandler() and generate vbitselect IL opcode when vector blend() operation is vectorized.

Signed-off-by: midronij <jackie.midroni@ibm.com>
@midronij
Copy link
Contributor Author

@gita-omr @IBMJimmyk could you please review when you have a chance?

@gita-omr
Copy link
Contributor

Great code reuse! LGTM.

@gita-omr
Copy link
Contributor

Jenkins test sanity win jdk8,jdk11,jdk19

@gita-omr
Copy link
Contributor

gita-omr commented Dec 1, 2022

Jenkins test sanity all jdk8,jdk11,jdk19

Copy link
Contributor

@IBMJimmyk IBMJimmyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really familiar with the details of this area but this seems good to me.

@gita-omr
Copy link
Contributor

gita-omr commented Dec 5, 2022

Investigating why the builds did not finish.

@gita-omr
Copy link
Contributor

gita-omr commented Dec 5, 2022

Jenkins was rebooted. Starting again.

@gita-omr
Copy link
Contributor

gita-omr commented Dec 5, 2022

Jenkins test sanity all jdk8,jdk11,jdk19

@midronij midronij changed the title Enable vectorized blend() IL opcode WIP: Enable vectorized blend() IL opcode Dec 5, 2022
@gita-omr
Copy link
Contributor

gita-omr commented Dec 6, 2022

The s390x failure is most likely unrelated.

@gita-omr
Copy link
Contributor

Jenkins test sanity all jdk8,jdk11,jdk19

@gita-omr
Copy link
Contributor

gita-omr commented Feb 1, 2023

Jenkins test sanity aix,amax jdk8,jdk11,jdk19

@midronij
Copy link
Contributor Author

midronij commented Feb 2, 2023

Since eclipse-omr/omr#6875 has been merged, this PR should also be ready to go as well

@midronij midronij changed the title WIP: Enable vectorized blend() IL opcode Enable vectorized blend() IL opcode Feb 2, 2023
@gita-omr
Copy link
Contributor

gita-omr commented Feb 2, 2023

I think mac and aix failures are unrelated.

@gita-omr gita-omr merged commit cf3c1ee into eclipse-openj9:master Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants