-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit test for accelerated CRC32C.update on Z #16404
Add unit test for accelerated CRC32C.update on Z #16404
Conversation
227dc2c
to
c4e2a2c
Compare
c4e2a2c
to
ca887be
Compare
ca887be
to
12210b7
Compare
Signed-off-by: Spencer Comin <spencer.comin@ibm.com>
12210b7
to
d5adff3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llxia Can you please review and merge these changes?
@llxia Ping to check if you get chance to review Spencer's changes ? Would appreciate if you merge them if you are OK with changes. |
Sorry, this slipped off my radar. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This doesn't compile on Java 8 since there is no java.util.zip.CRC32C |
Until it can be fixed, reverted via #16697 |
Test for correctness in accelerated CRC-32C calculation recently implemented for Z #16379.