Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify the flag setting for uninitializedThis in the stackmaps #16423

Merged

Conversation

ChengJin01
Copy link

The changes are to fix the issue with the flags setting intended for uninitializedThis
in the stackmaps so as to match the JVM Spec and the RI's behavior by explicitly
outputting the detailed error messages for the mismatch captured in the stackmaps.

Internal ref 147737

Signed-off-by: ChengJin01 jincheng@ca.ibm.com

The changes are to fix the issue with the flags setting intended
for uninitializedThis in the stackmaps so as to match the JVM Spec
and the RI's behavior by explicitly outputting the detailed error
messages for the mismatch captured in the stackmaps.

Internal ref 147737

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01
Copy link
Author

The PR was verified in internal builds & open source builds and the expected detailed message is something like:

Exception Details:
  Location:
    c.<init>(...)V @4: JBifnonnull
  Reason:
    Current frame's flags are not assignable to stack map frame's.
  Current Frame:
    bci: @4
    flags: { flagThisUninit }
    locals: { 'uninitializedThis', 'A', 'B', 'jC', integer, integer }
    stack: { 'uninitializedThis', 'A', 'B' }
  Stackmap Frame:
    bci: @11
    flags: { }
    locals: { top, top, top, 'jC', integer, integer }
    stack: { 'uninitializedThis', 'A', 'B' }
  Stackmap Table:
    full_frame(@11,{top,top,top,Object[#25],integer,integer},{uninitializedThis,Object[#182],Object[#183]})
    full_frame(@23,{top,top,top,top,top,integer},{uninitializedThis,Object[#182],Object[#183],Object[#184]})

Reviewer: @DanHeidinga
FYI: @tajila, @pshipton, @gacholio

@DanHeidinga
Copy link
Member

Jenkins test sanity xlinux jdk17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants