Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multi-dimensional stable arrays #16522

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

gita-omr
Copy link
Contributor

@gita-omr gita-omr commented Jan 8, 2023

  • derive array dimension from the signature
  • create known object with a stable array rank that is equal to array's dimension
  • when dereferencing stable array, create a known object that is stable array with rank-1 (unless new rank is 0).

@gita-omr
Copy link
Contributor Author

gita-omr commented Jan 8, 2023

Jenkins test sanity all jdk8,jdk19

@gita-omr
Copy link
Contributor Author

gita-omr commented Jan 9, 2023

Jenkins test sanity ppc64_aix,x86-64_mac jdk8,jdk19

@gita-omr gita-omr changed the title WIP: Handle multi-dimensional stable arrays Handle multi-dimensional stable arrays Jan 9, 2023
runtime/compiler/optimizer/J9TransformUtil.cpp Outdated Show resolved Hide resolved
@gita-omr gita-omr force-pushed the stable_multi_dimensional branch from a6426b6 to 82e6b04 Compare January 10, 2023 03:01
@gita-omr
Copy link
Contributor Author

Addressed comments.

@jdmpapin
Copy link
Contributor

Jenkins test sanity all jdk8,jdk11,jdk17

@jdmpapin jdmpapin self-assigned this Jan 10, 2023
@jdmpapin
Copy link
Contributor

jdmpapin commented Jan 10, 2023

All checks have passed. Please amend the commit message to remove the "WIP:" prefix left over at the start of its subject line. (Sorry, I didn't notice it before starting the builds.)

- derive array dimension from the signature
- create known object with a stable array rank that is equal to array's dimension
- when dereferencing stable array, create a known object that is stable array with rank-1
(unless new rank is 0).
@gita-omr gita-omr force-pushed the stable_multi_dimensional branch from 82e6b04 to 265b607 Compare January 11, 2023 22:54
@gita-omr
Copy link
Contributor Author

Removed WIP from the commit message.

@jdmpapin
Copy link
Contributor

The latest push changed only the commit message, so all checks have already passed on this code. Merging.

@jdmpapin jdmpapin merged commit 62302ae into eclipse-openj9:master Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants