Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using sprintf() in SharedCacheAPITest.cpp #16550

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Stop using sprintf() in SharedCacheAPITest.cpp #16550

merged 1 commit into from
Jan 19, 2023

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jan 13, 2023 •
edited
Loading

This commit rewrites getCacheDir() in SharedCacheAPITest.cpp for
eliminating sprintf().

Signed-off-by: KONNO Kazuhiro konno@jp.ibm.com

@knn-k
Copy link
Contributor Author

knn-k commented Jan 13, 2023

This is a part of fixes for Issue #16517.
There are many other files that use sprintf(), but it seems SharedCacheAPITest.cpp is the only file in the OpenJ9 project that blocks the build with Xcode 14 at the moment.

@knn-k
Copy link
Contributor Author

knn-k commented Jan 13, 2023

Jenkins test sanity alinux64,amac jdk17 depends eclipse-omr/omr#6862

@knn-k knn-k mentioned this pull request Jan 13, 2023
Closed
@knn-k knn-k marked this pull request as ready for review January 13, 2023 05:47
@knn-k knn-k mentioned this pull request Jan 13, 2023
Merged
@knn-k knn-k requested a review from keithc-ca January 17, 2023 01:37
@knn-k
Stop using sprintf() in SharedCacheAPITest.cpp
2765fca 
This commit rewrites getCacheDir() in SharedCacheAPITest.cpp for
eliminating sprintf().

Signed-off-by: KONNO Kazuhiro <konno@jp.ibm.com>
@knn-k knn-k changed the title Replace sprintf() with snprintf() in SharedCacheAPITest.cpp Stop using sprintf() in SharedCacheAPITest.cpp Jan 18, 2023
@knn-k
Copy link
Contributor Author

knn-k commented Jan 18, 2023

Jenkins test sanity xlinux,amac jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Jan 18, 2023

It seems build machines are not available today.

@keithc-ca
Copy link
Contributor

Jenkins test sanity zlinux jdk17

@knn-k
Copy link
Contributor Author

knn-k commented Jan 19, 2023

Jenkins test sanity xlinux,amac jdk17

@keithc-ca keithc-ca merged commit ce5f39f into eclipse-openj9:master Jan 19, 2023
@knn-k knn-k deleted the useSnprintf branch January 19, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@knn-k @keithc-ca