Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test/FFI] Change the alignment of long in JDK17 #16566

Merged

Conversation

ChengJin01
Copy link

@ChengJin01 ChengJin01 commented Jan 17, 2023

The change is to change the alignment for the long type in the case of
the [int, double, long] struct on AIX as it proves to work in JDK19.

Fixes: #16561

Signed-off-by: ChengJin01 jincheng@ca.ibm.com

The change is to change the alignment for the long
type in the case of the [int, double, long] struct
on AIX as it proves to work in JDK19.

Fixes: eclipse-openj9#16561

Signed-off-by: ChengJin01 <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the ffi_test_update_long_alignment__jdk17 branch from 9e844c5 to b7cc8c3 Compare January 17, 2023 19:54
@ChengJin01
Copy link
Author

Reviewer: @tajila
FYI: @pshipton

@ChengJin01 ChengJin01 requested a review from tajila January 17, 2023 20:01
@pshipton
Copy link
Member

This is the fix for #16561? If so pls add this to the description with a keyword to close it when merged.

@ChengJin01
Copy link
Author

This is the fix for #16561? If so pls add this to the description with a keyword to close it when merged.

Just added in the description.

@pshipton
Copy link
Member

@tajila any outlook for reviewing this? It's causing failures on jdk17, some of which block acceptance builds.

@tajila
Copy link
Contributor

tajila commented Jan 24, 2023

jenkins test sanity aix jdk17

@tajila tajila merged commit ab5679e into eclipse-openj9:master Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants