-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only call fixHiddenOrAnonSignature in Java 17+ #16613
Conversation
Should we #if out fixHiddenOrAnonSignature as well? jenkins compile amac jdk11 |
Yes, looks like the only caller is in |
For some reason the test doesn't always pass, but it can pass with this fix. When it fails it's due to what looks like a network problem.
Passing run: https://openj9-jenkins.osuosl.org/job/Grinder_iteration_0/204/ |
@ehrenjulzert after you add the #if around |
Fixes eclipse-openj9#16604 Signed-off-by: Ehren Julien-Neitzert <ehren.julien-neitzert@ibm.com>
11ab9b2
to
2b77db3
Compare
The #if is added in 2b77db3 , now I just need to make the other PR |
Other PR for v0.36.1-release: #16615 |
jenkins test sanity alinux64 jdk11 |
Fixes #16604
Signed-off-by: Ehren Julien-Neitzert ehren.julien-neitzert@ibm.com