Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show 0 for MaxDirectMemorySize with PrintFlagsFinal when unset #16639

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Show 0 for MaxDirectMemorySize with PrintFlagsFinal when unset #16639

merged 1 commit into from
Feb 7, 2023

Conversation

pshipton
Copy link
Member

Fixes #16637

java -XX:+PrintFlagsFinal

[Global flags]
   size_t MaxHeapSize                              = 2083651584                                {product} {ergonomic}
 uint64_t MaxDirectMemorySize                      = 0                                         {product} {ergonomic}

@pshipton pshipton requested a review from keithc-ca January 31, 2023 20:46
@pshipton pshipton mentioned this pull request Jan 31, 2023
Closed
keithc-ca
keithc-ca requested changes Jan 31, 2023
View reviewed changes
runtime/vm/jvminit.c Outdated Show resolved Hide resolved
keithc-ca
keithc-ca requested changes Feb 1, 2023
View reviewed changes
runtime/jcl/common/system.c Outdated Show resolved Hide resolved
runtime/vm/jvminit.c Outdated Show resolved Hide resolved
@pshipton
Show 0 for MaxDirectMemorySize with PrintFlagsFinal when unset
08802bc 
Issue eclipse-openj9#16637

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

pshipton commented Feb 1, 2023

Fixed the brackets.

@keithc-ca
Copy link
Contributor

Jenkins test sanity alinux64 jdk11

@keithc-ca keithc-ca merged commit be89be0 into eclipse-openj9:master Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MaxDirectMemorySize memory size reported by -XX:+PrintFlagsFinal is incorrect (i.e it's -1 by default)
2 participants
@pshipton @keithc-ca