Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JITServer problem determination documentation #16682

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

SajinaKandy
Copy link
Contributor

Add descriptions for new debugging options added to JITServer

@SajinaKandy
Copy link
Contributor Author

@mpirvu Can you review the updates made to the document?

@mpirvu mpirvu self-assigned this Feb 8, 2023
@mpirvu mpirvu added the comp:jitserver Artifacts related to JIT-as-a-Service project label Feb 8, 2023
@mpirvu mpirvu changed the title Update Problem.md Update JITServer problem determination documentation Feb 8, 2023
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some rephrasing for the last paragraph.
Please squash the two commits into one and also add "Signed-off-by: "

doc/compiler/jitserver/Problem.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mpirvu mpirvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please squash the 3 commits into one.

Add descriptions for new debugging options added to JITServer

Signed-off-by: Sajina Kandy <sajina.kandy@ibm.com>
@mpirvu
Copy link
Contributor

mpirvu commented Feb 8, 2023

Only documentation has changed, so running tests is not required.

@mpirvu mpirvu merged commit 076151b into eclipse-openj9:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jitserver Artifacts related to JIT-as-a-Service project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants