Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build jdk19+ Windows with VS 2022 #16705

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Conversation

pshipton
Copy link
Member

@pshipton pshipton commented Feb 10, 2023

Issue #16701

Created adoptium/temurin-build#3251 for the Adoptium pipelines.

Doc issue eclipse-openj9/openj9-docs#1055

Issue eclipse-openj9#16701

Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
@pshipton
Copy link
Member Author

jenkins test sanity,sanity.openjdk win jdk19,jdk20

@pshipton
Copy link
Member Author

The failure in Windows sanity.openjdk is a known issue.
#16657

@pshipton
Copy link
Member Author

@AdamBrousseau this is ready to go but we need to be ready internally before this is merged.

@AdamBrousseau
Copy link
Contributor

See #15495
I don't think the 2012 machines have VS2022.
Although we seem to only have the build label on a few machines at the moment.
https://openj9-jenkins.osuosl.org/label/sw.os.windows&&ci.role.build/
image
So if we aren't going back to compiles on the old 2012s then I think this is good as is.

@pshipton
Copy link
Member Author

So if we aren't going back to compiles on the old 2012s then I think this is good as is.

I'm not expecting to go back. Compiling on 2019s isn't perfect, as per #16515, but is the way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants