Pin virtual threads in JVMTI RawMonitorEnter and RawMonitorExit #16790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JVMTI functions RawMonitorEnter and RawMonitorExit can be invoked from Java code using native methods. ownedMonitorCount is incremented for the current J9VMThread in RawMonitorEnter after successfully acquiring the monitor, and it is decremented for the current J9VMThread in RawMonitorExit after successfully releasing the monitor. This prevents virtual threads to yield if it owns a monitor. Related: eclipse-openj9#16753 Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
tajila
approved these changes
Feb 28, 2023
|
jenkins compile win jdk8 |
|
jenkins test sanity alinux64 jdk19 |
|
@pshipton This PR is needed for Java 19. Should it be backported to both 0.37 and 0.38 release branches? |
|
I think we decided that the JDK19 M1 would be split from head since we weren't very diligent in backporting JDK19 changes |
|
This only affects Java 19 / virtual threads? If so it's only needed in 0.37 branches. |
|
We split Java 19 (0.37) at the same time as 0.38, on Feb 21. |
Okay, I missed that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JVMTI functions RawMonitorEnter and RawMonitorExit can be invoked
from Java code using native methods.
ownedMonitorCount is incremented for the current J9VMThread in
RawMonitorEnter after successfully acquiring the monitor, and
it is decremented for the current J9VMThread in RawMonitorExit
after successfully releasing the monitor.
This prevents virtual threads to yield if it owns a monitor.
Related: #16753