(0.37) Fixing wrong address elementSize calculation #16946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generateReportFieldAccessOutlinedInstructions incorrectly believes that when it is run on a awrtbar/awrtbari node and compressed refs is active, it is being passed a compressed object address to pass into a call to the VM. In reality, it is being given an uncompressed object address and the VM is expecting an uncompressed value. This causes a problem where a stw instruction is used to store a 64 bit value. This change removes the special case handling of a compressed ref value for calculating elementSize. By default, convertTypeToSize already returns the correct value of 8 for 64 bit (and 4 for 32 bit). Issue: eclipse-openj9#16750 Signed-off-by: jimmyk <jimmyk@ca.ibm.com>
pshipton
changed the title
pshipton
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generateReportFieldAccessOutlinedInstructions incorrectly believes that when it is run on a awrtbar/awrtbari node and compressed refs is active, it is being passed a compressed object address to pass into a call to the VM. In reality, it is being given an uncompressed object address and the VM is expecting an uncompressed value. This causes a problem where a stw instruction is used to store a 64 bit value.
This change removes the special case handling of a compressed ref value for calculating elementSize. By default, convertTypeToSize already returns the correct value of 8 for 64 bit (and 4 for 32 bit).
Issue: #16750
Port of #16925