Throw NoClassDefFoundError: MH.resolveInvokeDynamic(...) #20
Conversation
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
from
f99a4a5 to
0ce9d83
Compare
babsingh
changed the title
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
from
0ce9d83 to
76de5dc
Compare
babsingh
changed the title
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
4 times, most recently
from
a724832 to
5961bb5
Compare
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
from
5961bb5 to
479e552
Compare
babsingh
changed the title
|
@AdamBrousseau the builds are failing without any errors. same issue noticed for #19. |
|
@babsingh Did you force push at some point? The builds get confused when the sha they expect isn't in the repo anymore |
|
@DanHeidinga yes. how to fix this issue? |
|
I've restarted the build on travis. Let's see if it passes now |
|
@DanHeidinga the build still failed. |
| * Retrieve the class name of the constant pool class element located at the specified | ||
| * index in clazz's constant pool. Then, throw a NoClassDefFoundError with the cause | ||
| * set as ClassNotFoundException. The message of NoClassDefFoundError and | ||
| * ClassNotFoundException contains the name of the class, which couldn't be found. |
There was a problem hiding this comment.
Can you add javadoc style comment for the arguments / return types?
| @@ -459,6 +459,41 @@ Java_sun_reflect_ConstantPool_getFieldAtIfLoaded0(JNIEnv *env, jobject unusedObj | |||
| } | |||
|
|
|||
| jobject JNICALL | |||
| Java_java_lang_invoke_MethodHandle_getClassNameAt(JNIEnv *env, jobject unusedObject, jobject constantPoolOop, jint cpIndex) | |||
There was a problem hiding this comment.
Please a function comment that describes the arguments, the return types and any invariants.
| * set as ClassNotFoundException. The message of NoClassDefFoundError and | ||
| * ClassNotFoundException contains the name of the class, which couldn't be found. | ||
| */ | ||
| private static Throwable noClassDefFoundError(Class<?> clazz, int index) { |
There was a problem hiding this comment.
Its totally a nitpick, but can you call this throwNoClassDefFoundError(...)? so it will match the naming convention in the j.l.i. package for these kinds of methods
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
2 times, most recently
from
a51643d to
121b44d
Compare
babsingh
changed the title
| * Get the class name from a constant pool class element, which is located at the | ||
| * specified index in clazz's constant pool. | ||
| */ | ||
| private static final native String getClassNameAt(Class<?> clazz, int index); |
There was a problem hiding this comment.
My apologies - I missed a naming convention issue. All the other MH-constantPool related methods have a CP prefix - i.e.: getCPClassNameAt
see:
Java_java_lang_invoke_MethodHandle_getCPTypeAt
Java_java_lang_invoke_MethodHandle_getCPMethodTypeAt
Java_java_lang_invoke_MethodHandle_getCPMethodHandleAt
And Javadoc the method as well please.
There was a problem hiding this comment.
changed name to getCPClassNameAt, added Java doc for getCPClassNameAt, and resolved merge conflicts that arose from merging #19
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
from
121b44d to
ee14d38
Compare
If ConstantPool.getClassAt(...) returns null while resolving bootstrap method handles, then we should throw NoClassDefFoundError, and the cause of NoClassDefFoundError should be ClassNotFoundException. The message of NoClassDefFoundError and ClassNotFoundException should contain the name of the class, which wasn't found. Signed-off-by: Babneet Singh <sbabneet@ca.ibm.com>
babsingh
force-pushed
the
jcl_npe_to_ncdfe
branch
from
ee14d38 to
a45bf26
Compare
|
Jenkins test sanity |
|
This is ready to merge once the sanity builds pass. |
|
@DanHeidinga Sanity Tests have failed due to the following error: |
|
jenkins test sanity |
this was a temporarily problem as a PR was merged before the required OMR content had promoted. |
Disable Windows OpenJ9 Java 8 builds temporarily
* Updated JVMImageHeader and fixed reading from file * Formatting fixup * Moved the header's buffer to the stack Signed-off-by: Brady Jessup <Brady.Jessup@ibm.com>
…e-queries Move value type query methods to ClassEnv
If ConstantPool.getClassAt(...) returns null while resolving bootstrap
method handles, then we should throw NoClassDefFoundError, and the
cause of NoClassDefFoundError should be ClassNotFoundException. The
message of NoClassDefFoundError and ClassNotFoundException should
contain the name of the class, which wasn't found.
Signed-off-by: Babneet Singh sbabneet@ca.ibm.com