Implement class relationship recording and validating #7089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Store class relationships (child and its superclass/superinterface relationships) in a hash table (saved in the class loader) instead of loading the classes and verifying them upfront. Each child (source class) table entry contains a list of its parents (target classes), with parent nodes being added as they are encountered. Enable feature using `-XX:+ClassRelationshipVerifier`. Disable feature using `-XX:-ClassRelationshipVerifier`. Throw error if `-Xfuture` is used with `-XX:+ClassRelationshipVerifier`. Note that `-Xverify:all` also enables `-Xfuture`. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
Currently, the code always adds the relationship even if it has already been added. This can lead to very long lists of parents which delays processing them. The insight here is that by keeping the list in the order of the classname length, we can more quickly weed out duplicates as we only need to walk the list until there is a longer name, or the same name already present, before inserting. Additionally, avoid the parent node allocation until we know we’re adding something to the list. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
When a class is being initialized, validate that it holds the expected relationship with each parent in its list. Free memory for the child hash table entry and parent nodes once validation is complete. Throw java/lang/VerifyError if validation of class relationships fails. Note that this validation check can be moved to any point prior to a class being made available. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
Instead of allocating a parent node for Throwable, set a bit in the childEntry flags J9RELATIONSHIP_PARENT_IS_THROWABLE. During validation, check if the bit is set. If so, retrieve the Throwable class and check that it is a superclass of the child. Throwable seems to occur frequently as a parent class, so this change will avoid the duplicate memory allocations done for Throwable. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
DanHeidinga
reviewed
Sep 16, 2019
|
Jenkins test sanity plinux,aix,zlinux jdk8 |
|
Jenkins test sanity win,osx,xlinux jdk11 |
|
I see all the tests have passed. @sharon-wang can you push the doc update? |
Reduce amount of white space used between parameters and their descriptions. Signed-off-by: Sharon Wang <sharon-wang-cpsc@outlook.com>
|
@DanHeidinga reformatting changes are now pushed |
|
The travis compile has passed so I won't require another rebuild |
This was referenced Oct 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store class relationships to delay verifying class compatibility (child, parent relationships) until triggered by class loading, instead of verifying compatibility upfront. Validate relationships for a class during class initialization, throwing a Verify Error if validation fails.
Enable using
-XX:[+/-]ClassRelationshipVerifier. Cannot be used with-Xfuture.Documentation issue: eclipse-openj9/openj9-docs#360
Testing will be added in a future PR.