Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Java version from 11 to 17 in the GitHub actions definition f… #20

Merged
merged 4 commits into from
Feb 13, 2023
Merged

Updated Java version from 11 to 17 in the GitHub actions definition f… #20

merged 4 commits into from
Feb 13, 2023

Conversation

deanone
Copy link
Contributor

@deanone deanone commented Feb 8, 2023

…ile.

@deanone deanone added the github_actions Pull requests that update GitHub Actions code label Feb 8, 2023
reimer-atb
reimer-atb requested changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@reimer-atb reimer-atb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might make sense to also update the java image in Dockerfile to a temurin-based java 17, given that java 16 and adoptopenjdk are EOL and not maintained anymore.

Maybe also update javaversion in pom.xml. Spring boot 3 fully supports Java 17.

.github/workflows/publish_api_gateway_image.yml Outdated Show resolved Hide resolved
deanone
deanone commented Feb 10, 2023
View reviewed changes
Dockerfile Show resolved Hide resolved
deanone
deanone commented Feb 10, 2023
View reviewed changes
pom.xml Show resolved Hide resolved
@deanone deanone merged commit 964eea6 into eclipse-opensmartclide:main Feb 13, 2023
@deanone deanone mentioned this pull request Feb 13, 2023
Closed
@deanone deanone deleted the fix-compile-error-08-02-2023 branch February 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimer-atb reimer-atb reimer-atb approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deanone @reimer-atb