Fix the issue c.expectConnack goroutine doesn't exit #101 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daichi Tomaru <banaoa7543@gmail.com>
|
Thanks for doing this - sorry for the delay in reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is for fixing #101. As I commented in the GitHub issue, it can be easily reproduced and causes goroutine leak (memory leak). After the patch is applied, it cannot be reproduced by the reproduction code in the GitHub issue.
To prevent the issue c.expectConnack goroutine doesn't exit, caPacketCh and caPacketErr is changed to buffered channels from unbuffered one. comment are also added so that the buffers won't get deleted in future fixes.
closes #101