Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix “opts_.connectProperties” didn't update when copyed and assigned #426

Closed
wants to merge 1 commit into from

Conversation

0sunshine
Copy link

No description provided.

@fpagliughi
Copy link
Contributor

Thanks for the PR! Unfortunately I was never able to merge this without an Eclipse ECA. But I'll get it in.

@fpagliughi
Copy link
Contributor

Actually, this wasn't the correct way to do this. It fails any time the caller tries to make a v3.x connection, because v3 requires that the connectProperties pointer in the options is NULL.

The copy and move functions were handling the specific case when the original object had a non-NULL pointer. But perhaps there was an edge case that didn't work properly? I'll refactor it along these lines to make it more resilient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants