Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to reflect new method #817

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Conversation

clmcavaney
Copy link
Contributor

I saw that rc == was shown in an example for "NEW code" but the code snippet parameter is reason_code
If I am correct, this pull request should fix that.

@PierreF
Copy link
Contributor

PierreF commented Feb 25, 2024

thank for spotting this mistake, indeed rc was renamed into reason_code.
Could you sign the ECA (https://accounts.eclipse.org/user/eca) so I can merge your contribution ?

@clmcavaney
Copy link
Contributor Author

Done

@PierreF PierreF merged commit 6135207 into eclipse-paho:master Feb 25, 2024
9 of 10 checks passed
@PierreF
Copy link
Contributor

PierreF commented Feb 25, 2024

Thank for your contribution

@clmcavaney clmcavaney deleted the minor-doco-update branch February 26, 2024 04:40
@PierreF PierreF added this to the 2.1.0 milestone Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants