Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special treatment of org.eclipse.swt in API-Tools #1094

Merged

Conversation

HannesWell
Copy link
Member

Now that eclipse-platform/eclipse.platform.swt#1008 is submitted, I think we can remove the special treatment of SWT and its fragments, since they should simply be compared against the baseline as they are.
Fixes #1084

Copy link

github-actions bot commented Jan 31, 2024

Test Results

   290 files  ±0     290 suites  ±0   54m 57s ⏱️ - 17m 6s
 3 526 tests ±0   3 467 ✅ ±0   58 💤 ±0  1 ❌ ±0 
10 823 runs  ±0  10 658 ✅ ±0  164 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 35976cd. ± Comparison against base commit 792018e.

♻️ This comment has been updated with latest results.

@akurtakov
Copy link
Member

This reminds me of dropping SWT special treatment in Tycho. It's so nice to see SWT being less and less of an exception. Thanks @HannesWell !

@laeubi
Copy link
Contributor

laeubi commented Jan 31, 2024

@akurtakov As far as I know Tycho has long time ago dropped special treatment of SWT, this is now handled by p2.inf + filters and was even improved thanks to @merks adding new testcases, also note that p2.inf customization is not special to swt,its even used in JDT / PDE / Equinox.

@HannesWell HannesWell merged commit 530e7a7 into eclipse-pde:master Feb 11, 2024
11 of 17 checks passed
@HannesWell HannesWell deleted the remove-special-swt-handling branch February 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove special treatment of org.eclipse.swt in API-Tools
3 participants