Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix file Utils regression #661 #662

Merged
merged 1 commit into from
Jul 11, 2023
Merged

fix file Utils regression #661 #662

merged 1 commit into from
Jul 11, 2023

Conversation

jukzi
Copy link
Contributor

@jukzi jukzi commented Jul 11, 2023

fixes regressions from a2612ef
for example:

"FileAlreadyExistsException: license.html" in
org.eclipse.pde.build.internal.tests.p2.PublishingTests.testBug266488()

"p2.inf doesn't exist" in
org.eclipse.pde.build.internal.tests.p2.PublishingTests.testBug271373()

fixes regressions from a2612ef
for example:

"FileAlreadyExistsException: license.html" in
org.eclipse.pde.build.internal.tests.p2.PublishingTests.testBug266488()

"p2.inf doesn't exist" in
org.eclipse.pde.build.internal.tests.p2.PublishingTests.testBug271373()
@jukzi jukzi linked an issue Jul 11, 2023 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Jul 11, 2023

Test Results

     252 files  +       6       252 suites  +6   58m 50s ⏱️ + 18m 3s
  3 293 tests  -        1    3 269 ✔️ +       1  24 💤 ±  0  0  - 1 
10 176 runs  +2 721  10 104 ✔️ +2 699  72 💤 +24  0  - 1 

Results for commit 8ab6126. ± Comparison against base commit c8754be.

This pull request removes 1 test.
AllPDEMinimalTests org.eclipse.pde.ui.tests.launcher.AllLauncherTests org.eclipse.pde.ui.tests.launcher.FeatureBasedLaunchTest ‑ Unknown test

♻️ This comment has been updated with latest results.

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@HannesWell
Copy link
Member

Lets merge this now so that hopefully some tests in the I-builds are fixed.
This also conflicts with #660 and I can then resolve the conflicts.

@HannesWell HannesWell merged commit 13c0d89 into eclipse-pde:master Jul 11, 2023
@jukzi jukzi deleted the 661 branch July 12, 2023 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

org.eclipse.pde.build.internal.tests.p2.PublishingTests fails
3 participants