Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[I-Build-Tests] Define Mac and Windows jobs as Jenkins-pipeline #2004

Conversation

HannesWell
Copy link
Member

@HannesWell HannesWell commented Apr 29, 2024

This allows to unify the job definition with the test-jobs for Linux and also allows to simplify some parts of the job a lot.

It also removes the testSuite parameter only available in mac tests, since anybody that wants to run another suite than all can just Replay the build in the Jenkins web-interface and adjust the suite as desired.

Especially the Windows pipeline needs some more local testing, e.g. with regards to spanning a command over multiple lines, but nevertheless I still would like to gather some early feedback.

This allows to unify the job definition with the test-jobs for Linux and
also allows to simplify some parts of the job a lot.
@HannesWell HannesWell force-pushed the iBuild-Tests-Win+Mac-as-pipeline branch from da7199f to c453c37 Compare April 30, 2024 20:01
@HannesWell HannesWell marked this pull request as ready for review April 30, 2024 20:01
@HannesWell
Copy link
Member Author

With the testing I did in my local Jenkins instance I'm relatively confident that this change is fine (at least syntax-wise).

I'll submit this now, deploy the new test-job definitions and trigger the affected ones to see if they at least start up as expected. Tonight's I-build will then verify if everything is completely working as expected.

@HannesWell HannesWell merged commit 74f4610 into eclipse-platform:master Apr 30, 2024
2 of 4 checks passed
@HannesWell HannesWell deleted the iBuild-Tests-Win+Mac-as-pipeline branch April 30, 2024 20:14
@HannesWell
Copy link
Member Author

In order to re-generate the jobs with another type (pipelineJob instead of job) no item with the same id was permitted to exist before. Therefore I renamed the existing configuration and appended the suffix -old.

I assume the execution history is not that important and we can delete them as soon as the new configuration has proofen itself fully functional.

Until now I have already verified that the jobs start as expected and as planned, tonight's I-build will verify the entire pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant