-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] Simplify bootstrapping of I-build tests and fetch configuration files directly from git #2609
base: master
Are you sure you want to change the base?
[Build] Simplify bootstrapping of I-build tests and fetch configuration files directly from git #2609
Conversation
Does anyone know where exactly the push of the folder |
08aeae3
to
f6f63e4
Compare
I requested from the infra-team to install git on all test machines, which is a prerequisite for this change: |
f6f63e4
to
96d2461
Compare
b13261b
to
780400b
Compare
With the latest unification of Y-build-tests and smoke tests this now required many files less to adjust. |
780400b
to
6b59311
Compare
And can anybody tell which job or part (maybe of the I-build?) transfers the content of Once that job/step is identified and this is submitted, I think it should be stopped and the current content should be deleted. |
I found a scheduled Job https://ci.eclipse.org/releng/job/Publish_shell_scripts_for_releng_jobs/ which publish scripts. |
Please keep in mind https://bugs.eclipse.org/bugs/show_bug.cgi?id=578862#c1 . This rate limit is what forced us to copy scripts to download - to not hit the download limit. |
Thanks! That looks promising.
That's of course a problem. Especially since we cannot control what other projects do. But I see multiple solutions:
|
GitHub is generally quite shy about their rate-limiting. See github/docs#8031, for example. In your case, I would suggest trying authenticated calls as described in https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/912#note_570713. |
I have now created #2645 to perform the deployment as part of the master branch build, similar to the deployment of the parent-pom.
Thanks for that hint. That would be an option, but since I would also like to keep it simple at the caller side I think we should just continue with the Eclipse download-server approach, probably reducing the number of stored files to the necessary minimum. And with #2645, maintaining that space should be simpler and better to understand. |
Prerequisite for - eclipse-platform#2609
Prerequisite for - eclipse-platform#2609
6b59311
to
6c79cc1
Compare
Now that #2645 is available I have implemented it and took the opportunity of the rename to shorten the path to the Additionally this also needs the following change, respectively the part of it to install git into the docker-images: Once that's submitted, this should be ready after a final round of testing. |
Prerequisite for - eclipse-platform#2609
Instead of fetching the test-configuration files from eclipse.downloads and push it there in each I-build, simply get the test-configuration files directly from the eclipse.platform.releng.aggregator git repository, using partial-clones for improved performance: - https://git-scm.com/docs/partial-clone - https://github.blog/open-source/git/get-up-to-speed-with-partial-clone-and-shallow-clone/ This avoids the need to pack and upload the test-configuration zip-file and also simplifies fetching the test-configuration for other branches, like maintenance branches or to test changes. This also removes from the getEBuilder.xml ant script the possibility to download the test-configuration zip file and to use a local zip. Furthermore this removes from the I-/Y-builds the creation and publication of the test-configuration zip-file.
6c79cc1
to
e107b2e
Compare
Remove the definitions of the properties 'EBUILDER_HASH' and 'downloadURL', which are not necessary anymore to be passed to the 'getEBuilder' ant-script. And remove the 'eclipseStream' property that now can be computed by the 'getEBuilder' ant-script. Also rename the folder containing the getEBuilder.xml from to just 'bootstrap' since Hudson is not used anymore and simplify the path to the getEBuilderxml at the download server.
e107b2e
to
581bf07
Compare
Instead of fetching the test-configuration files from eclipse.downloads and push it there in each I-build, simply get the test-configuration files directly from the eclipse.platform.releng.aggregator git repository, using partial-clones for improved performance:
This avoids the need to pack and upload the test-configuration zip-file and also simplifies fetching the test-configuration for other branches, like maintenance branches or to test changes.
This also removes from the getEBuilder.xml ant script the possibility to download the test-configuration zip file and to use a local zip.
Furthermore this removes from the I-/Y-builds the creation and publication of the test-configuration zip-file.
As a consequence remove the definitions of the properties
EBUILDER_HASH
anddownloadURL
that are not necessary anymore to be passed to thegetEBuilder
ant-script. And remove theeclipseStream
property that now can be computed by the 'getEBuilder' ant-script.Also rename the folder containing the
getEBuilder.xml
from to justbootstrap
since Hudson is not used anymore.